Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal accessibility #633

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Aug 28, 2022

I noticed that in the SelectEmoteSet modal, the "buttons" don't have any tooltip. This can make discovering the purpose of a button hard. In addition, all the buttons in this dialog are divs. Furthermore, the modal isn't maked as a dialog/modal to the browser.

This PR attempts to fix these issues while maintaining the style of the old buttons. With the core component being UnstyledButton that, as the name suggests, is a button that's styled like a div.

There's one more issue that's out of scope (i think): The dialog should have a focus trap, so elements behind it can't be tabbed. There's a hook in vueuse for it, but at this point why not use something like @headlessui/vue which implements a plain, accessible dialog. Elements behind the dialog cannot be tabbed now.

The PR only modifies the SelectEmoteSet dialog, future PRs could modify other dialog.

@Nerixyz Nerixyz marked this pull request as ready for review September 5, 2022 17:36
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants