-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modal accessibility #633
Open
Nerixyz
wants to merge
11
commits into
SevenTV:dev
Choose a base branch
from
Nerixyz:fix/accessibility
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
fix/accessibility
branch
from
September 5, 2022 17:35
0731d5a
to
d477b3d
Compare
AnatoleAM
force-pushed
the
dev
branch
6 times, most recently
from
December 6, 2023 02:52
011df67
to
f17bf90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the
SelectEmoteSet
modal, the "buttons" don't have any tooltip. This can make discovering the purpose of a button hard. In addition, all the buttons in this dialog arediv
s. Furthermore, the modal isn't maked as a dialog/modal to the browser.This PR attempts to fix these issues while maintaining the style of the old buttons. With the core component being
UnstyledButton
that, as the name suggests, is abutton
that's styled like adiv
.There's one more issue that's out of scope (i think): The dialog should have a focus trap, so elements behind it can't be tabbed. There's a hook in vueuse for it, but at this point why not use something likeElements behind the dialog cannot be tabbed now.@headlessui/vue
which implements a plain, accessible dialog.The PR only modifies the
SelectEmoteSet
dialog, future PRs could modify other dialog.