Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional buttons for handhelds Legion Go and OneXPlayer. #18

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

CasperH2O
Copy link
Contributor

@CasperH2O CasperH2O commented Nov 11, 2023

Several new buttons used by the new Lenovo Legion Go and two that I missed last time for the OneXPlayer.

@CasperH2O
Copy link
Contributor Author

CasperH2O commented Nov 11, 2023

Hey @Shinmera , another set. There's been some developments, multiple OEMs are now using M1 and M2, perhaps we should remove the ROG Ally prefix for those?

@CasperH2O
Copy link
Contributor Author

Hey @Shinmera is this PR OK or missing something? Is it just a matter of finding the time to sort it (I can relate)?

@Shinmera
Copy link
Owner

Fell by the wayside again, sorry about that. Will try to look into it in the coming days.

@CasperH2O
Copy link
Contributor Author

Ah, excellent! We were aiming for a public release this weekend and it would be lovely to include the full set of icons. No rush though, it's ready when it's ready. 😇

@Shinmera Shinmera merged commit 7694634 into Shinmera:master Nov 26, 2023
1 check passed
Shinmera added a commit that referenced this pull request Nov 26, 2023
@Shinmera
Copy link
Owner

Done. Good luck for the release. In the future if you need things urgently, the contribution guide includes a short explanation on how to add glyphs into the font yourself.

@CasperH2O
Copy link
Contributor Author

@Shinmera thank you! I'll keep that in mind for next time and give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants