Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional buttons for gamepad and Steam Deck. #8

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

CasperH2O
Copy link
Contributor

As discussed in #2 , additional buttons we'd like to use in Handheld Companion.

@Shinmera Shinmera merged commit f7dddee into Shinmera:master Mar 19, 2023
@Shinmera
Copy link
Owner

Thanks, will get to adding them into the font soon.

@Shinmera
Copy link
Owner

Ok, they're now in. I had to fix up all of the SVGs though, as they were not in the correct size and were missing the margins. Some also were composed out of multiple shapes, rather than a singular shape.

Please for future PRs ensure that each SVG is of the same document size as the existing ones. That makes importing them into the font a lot easier.

@CasperH2O
Copy link
Contributor Author

@Shinmera thanks for the merge and the excellent feedback. I'll make sure to incorporate your feedback on the format for next round.

Perhaps something to add to the readme for future contributions? Shape size n x n pixels, n pixels margin, single shape, black color (#00000 ?) and transparent?

@CasperH2O
Copy link
Contributor Author

CasperH2O commented Mar 19, 2023

@Shinmera is it possible you overwrote your initial options menu icon (circular shape with 3 horizontal lines) with the SteamDeck one?

Edit: Nevermind, it's now called burger menu. All good!

afbeelding

@Shinmera
Copy link
Owner

No. That one's called the Burger Menu.

@CasperH2O CasperH2O deleted the AdditionalGamePadIcons branch November 11, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants