Move COPY method definitions. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpgoldman
force-pushed
the
reorder-copy
branch
from
caf470a to
7b70c85
Compare
Merged
|
If possible, it would be best to merge #33 first, which fixes up the regression tests (and is included here). |
Shinmera
force-pushed
the
master
branch
2 times, most recently
from
0a14094 to
0c1daed
Compare
Move them after the DEFGENERIC for COPY.
|
Had to catch up with a bunch of other merges, etc. This is now one simple commit, as it should be, and is ready for your review (assuming it passes tests). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were default
copymethod definitions in the file toolkit.lisp that was loaded before the (macro-generated)defgenericforcopy, in generator.lisp.This made SBCL grumpy, so I moved the two
copymethod definitions into generator.lisp.