Remove notinline declaration in CCL #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the versions of the actions we use: cache and checkout. Specify the lisp versions to install with roswell.
This has worked better than my by-hand version in the tests for XMLS.
CCL errors out when I declare `random` (as yet undefined) to be `notinline`. > ; In HISTOGRAM: INLINE declaration for unknown function RANDOM
|
Best to merge #34 before this. |
|
Suggest we drop this in favor of moving the histogram functions out of toolkit. See new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least some versions of CCL object to declaring the
randomfunctionnotinlinebefore defining it.I get an error claiming that I'm trying to make an
inlinedeclaration on a function not yet defined.