Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to check and see if RANDOM-STATE builds cleanly #37

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rpgoldman
Copy link
Contributor

Check to make sure that random-state builds w/o warnings on a wide variety of systems.

Interestingly, while this test passes for me locally, it fails when run as a GitHub action, with redefinition warnings on all lisps. Not sure why this is happening. @Shinmera any clue?

Failed to build cleanly: got STYLE-WARNINGs:
 redefining RANDOM-STATE::%INNER-XOSHIRO in DEFMACRO
 redefining RANDOM-STATE::%XORSHIFT in DEFMACRO
 redefining RANDOM-STATE::%INNER-MERSENNE-TWISTER in DEFMACRO
 redefining RANDOM-STATE:DEFINE-GENERATOR in DEFMACRO
 redefining RANDOM-STATE:COPY in DEFGENERIC
 redefining RANDOM-STATE::DEFINE-GENERATOR-FUN in DEFMACRO
 redefining RANDOM-STATE::UPDATE in DEFMACRO
 redefining RANDOM-STATE::INCFMOD in DEFMACRO

Update the versions of the actions we use: cache and checkout.

Specify the lisp versions to install with roswell.
This has worked better than my by-hand version in the tests for XMLS.
Fail on warnings or errors.
This would mistakenly not exit with a positive exit code if the
quicklisp setup failed (which it seems to do in GitHub actions).
@Shinmera Shinmera force-pushed the master branch 2 times, most recently from 0a14094 to 0c1daed Compare January 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant