Support function void argument #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 98.83% 98.83% +<.01%
==========================================
Files 26 26
Lines 3850 3852 +2
==========================================
+ Hits 3805 3807 +2
Misses 45 45
Continue to review full report at Codecov.
|
pfalcon
reviewed
Aug 4, 2019
shivyc/tree/nodes.py
Outdated
| @@ -668,6 +668,10 @@ def extract_params(self, decl): | |||
|
|
|||
| for param in func_decl.args: | |||
| decl_info = self.get_decl_infos(param)[0] | |||
| # check if void is the function argument,we skip | |||
There was a problem hiding this comment.
The patch (IMHO, as an outsider to the project) looks pretty clean, the only suggestion is with this code comment. Would be nice to reword/reformat it a bit, e.g. "check if "void" is the function argument, and skip it".
|
@ShivamSarodia: This seems to be more or less good patch, and definitely a needed feature, any response? |
Void argument is recommend to use inside the function which has no parameter.This commit can allow user define void during function declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Void argument is recommend to use inside the function which has
no parameter.This commit can allow user define void during function
declaration.