Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link cleans local scopes or required_scopes based on remote config #5312

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zzooeeyy
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.33% (-0.11% 🔻)
8895/11808
🟡 Branches
70.58% (-0.04% 🔻)
4327/6131
🟡 Functions
75.1% (-0.2% 🔻)
2337/3112
🟡 Lines
75.87% (-0.07% 🔻)
8407/11081
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / custom_data.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app.test-data.ts
92.51%
93.64% (-0.11% 🔻)
83.75% 92%
🟢
... / app.ts
86.49% (-1.01% 🔻)
70.37%
92.16% (-0.3% 🔻)
88.19% (-1.12% 🔻)
🟢
... / loader.ts
91.9% (-0.08% 🔻)
83.16%
96.19% (-0.04% 🔻)
92.62% (-0.08% 🔻)
🟢
... / extension-instance.ts
84.38% (-0.63% 🔻)
80% (-2.61% 🔻)
92.16% 85.03%
🟢
... / specification.ts
89.55% (-2.25% 🔻)
86.96%
88.46% (-6.78% 🔻)
87.93% (-2.45% 🔻)
🟢
... / flow_action.ts
90% (-10% 🔻)
100%
75% (-25% 🔻)
90% (-10% 🔻)
🟢
... / info.ts
81.44%
60.94% (-0.6% 🔻)
90.32% 83.15%
🟢
... / link.ts
95.65% (-0.9% 🔻)
91.43% (-1% 🔻)
100%
95.51% (-0.88% 🔻)
🟢
... / app-event-watcher.ts
93.83% (-2.56% 🔻)
86.49% (-2.7% 🔻)
90.48% (-4.98% 🔻)
98.61% (-1.39% 🔻)
🟢
... / file-watcher.ts
86.61% (-1.22% 🔻)
72.73% (-6.22% 🔻)
92% (-0.31% 🔻)
89.9% (-0.3% 🔻)
🟢
... / utilities.ts
82.35% (-5.88% 🔻)
80% (-10% 🔻)
100% 85.71%
🟢
... / dev-session.ts
83.56% (-1% 🔻)
66.67% (-0.98% 🔻)
85% (-2.8% 🔻)
89.68% (-0.24% 🔻)
🟢
... / setup-dev-processes.ts
95.45% (-0.1% 🔻)
82.14% (+3.57% 🔼)
90.91%
94.74% (-0.13% 🔻)
🟢
... / Dev.tsx
94.06% (+0.12% 🔼)
79.69% (-1.19% 🔻)
92%
94.68% (+0.06% 🔼)
🟢
... / serialize-fields.ts
95% (-2.5% 🔻)
87.5% (-3.13% 🔻)
100% 97.44%
🟡
... / build.ts
78.51% (-0.18% 🔻)
64.58% 78.38%
76.99% (-0.2% 🔻)
🟢
... / locales-configuration.ts
96.15%
90% (-1.67% 🔻)
100% 95.45%
🟢
... / Tasks.tsx
93.62% (-0.38% 🔻)
92% (-1.1% 🔻)
88.89%
93.18% (-0.44% 🔻)
🔴
... / crypto.ts
44.44% (-11.11% 🔻)
100%
37.5% (-12.5% 🔻)
44.44% (-11.11% 🔻)
🟡
... / fs.ts
66.67% (-2.22% 🔻)
93.75%
63.64% (-2.27% 🔻)
65.91% (-2.27% 🔻)
🟢
... / git.ts
88.73% (-1.51% 🔻)
87.18% (-1.71% 🔻)
87.5% (-1.39% 🔻)
90% (-1.25% 🔻)
🟢
... / json-schema.ts
91.86% (-1.69% 🔻)
82.05% (-4% 🔻)
100%
91.76% (-1.71% 🔻)

Test suite run success

2001 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from d792a71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant