Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump theme-tools packages #5327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump theme-tools packages #5327

wants to merge 2 commits into from

Conversation

graygilmore
Copy link
Contributor

@graygilmore graygilmore commented Jan 30, 2025

WHY are these changes introduced?

WHAT are these changes introduced?

Bumping the theme-tools packages.

@shopify/theme-check-node

Minor incremented 3.5.0 -> 3.7.1 (changelog)

Note

A number of changes will be in the theme-check-common package (changelog) which is treated as a dependency.

Compare

@shopify/theme-language-server-node

Minor incremented 2.3.3 -> 2.6.1 (changelog)

Note

A number of changes will be in the theme-language-server-common package (changelog) which is treated as a dependency.

How to test your changes?

theme-check

pnpm build
pnpm shopify:run theme check --path=<PATH TO THEME>

language-server

  1. Configure the language server following the instructions for one of these editors: https://github.com/Shopify/theme-tools/wiki (note: if using VS Code do not install the extension)
  2. Use the snapped version to test npm i -g @shopify/[email protected]
  3. Ensure any new features work (see changelog for more information)

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.46% (+0.01% 🔼)
9012/11943
🟡 Branches
70.65% (+0.02% 🔼)
4396/6222
🟡 Functions 75.26% 2364/3141
🟡 Lines
75.98% (+0.02% 🔼)
8514/11205
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
95.18% (-1.2% 🔻)
86.49% (-2.7% 🔻)
95.45% 100%

Test suite run success

2035 tests passing in 909 suites.

Report generated by 🧪jest coverage report action from 1525b25

@graygilmore
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @graygilmore! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@graygilmore graygilmore marked this pull request as ready for review January 31, 2025 18:02
@graygilmore graygilmore requested review from a team as code owners January 31, 2025 18:02
Comment on lines +2 to +3
'@shopify/theme': minor
'@shopify/app': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use patch for this kind of update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the same impression but @jamesmengo recently asked about it and we're meant to try to follow proper semver rules (even though the cli repo itself doesn't necessarily adhere to it).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isaacroldan Have we changed the policy around semver?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the context of the CLI this is a patch, but to be honest, it doesn't matter. We can leave it as a minor, we actually need at least one minor changeset between releases so is ok.

We are evaluating our semver policy, will keep you posted on that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, going to approve this then. Thanks!

@frandiox frandiox enabled auto-merge February 7, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: MissingSchema error for app extension while build Shopify app
4 participants