-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump theme-tools packages #5327
base: main
Are you sure you want to change the base?
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success2035 tests passing in 909 suites. Report generated by 🧪jest coverage report action from 1525b25 |
5787c1d
to
bdf9cac
Compare
bdf9cac
to
1525b25
Compare
/snapit |
🫰✨ Thanks @graygilmore! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
'@shopify/theme': minor | ||
'@shopify/app': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use patch for this kind of update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the same impression but @jamesmengo recently asked about it and we're meant to try to follow proper semver rules (even though the cli
repo itself doesn't necessarily adhere to it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isaacroldan Have we changed the policy around semver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of the CLI this is a patch, but to be honest, it doesn't matter. We can leave it as a minor, we actually need at least one minor changeset between releases so is ok.
We are evaluating our semver policy, will keep you posted on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, going to approve this then. Thanks!
WHY are these changes introduced?
WHAT are these changes introduced?
Bumping the
theme-tools
packages.@shopify/theme-check-node
Minor incremented
3.5.0
->3.7.1
(changelog)Note
A number of changes will be in the
theme-check-common
package (changelog) which is treated as a dependency.Compare
@shopify/theme-language-server-node
Minor incremented
2.3.3
->2.6.1
(changelog)Note
A number of changes will be in the
theme-language-server-common
package (changelog) which is treated as a dependency.How to test your changes?
theme-check
language-server
npm i -g @shopify/[email protected]
Checklist