Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop test:js from CLI Kit #5365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop test:js from CLI Kit #5365

wants to merge 1 commit into from

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Feb 5, 2025 •
edited
Loading

We no longer need the test:js task for CLI Kit, now that Ruby is exorcised from the repo. This simplifies our task graph.

@shauns Graphite App
Copy link
Contributor Author

shauns commented Feb 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shauns shauns mentioned this pull request Feb 5, 2025
Open
@shauns shauns marked this pull request as ready for review February 5, 2025 13:45
@shauns shauns requested a review from a team as a code owner February 5, 2025 13:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 75.57% 9048/11973
🟡 Branches 70.81% 4411/6229
🟡 Functions 75.36% 2373/3149
🟡 Lines
76.08% (+0.01% 🔼)
 8544/11230
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
95.18% (-1.2% 🔻)
86.49% (-2.7% 🔻)
 95.45% 100%

Test suite run success

2040 tests passing in 911 suites.

Report generated by 🧪jest coverage report action from 11999e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shauns @isaacroldan