Display field for app management errors #5368
Open
+43
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2487
We are not properly displaying app management errors - the field is not included in the error message.
Turns out this is due to discrepancies in the error format coming from Partners vs. App Management.
WHAT is this pull request doing?
Updates the error handling so we always display the field if available.
Note much of this PR is handling that
appVersion
is nullable (and will be null when the version fails to be created), which we weren't allowing for previously.How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist