Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit status events from dev-session #5374

Draft
wants to merge 1 commit into
base: 01-31-show_a_dynamic_dev_session_status_message_in_the_ui
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Feb 7, 2025

WHY are these changes introduced?

Improve DevSession feedback by showing the current status in the dynamic section of the terminal log footer.

WHAT is this pull request doing?

  • Adds specific error cause for app validation errors
  • Introduces new status message handlers for different dev session states (build errors, ready state, loading, etc.)
  • Ensures proper status updates when extensions are affected by changes

How to test your changes?

  1. Run dev command with dev-sessions enabled.
  2. Verify status messages appear correctly for:
    • Initial loading state
    • Build errors (make a bad change in a extension code)
    • Validation errors (make a bad change in a toml file)
    • Successful updates
    • Ready state
  3. Confirm status message automatically resets to "Ready" 2 seconds after an update

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Feb 7, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.5% (+0% 🔼)
9067/12009
🟡 Branches
70.78% (+0.01% 🔼)
4420/6245
🟡 Functions 75.21% 2379/3163
🟡 Lines
76.01% (+0% 🔼)
8563/11265
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
88% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

2044 tests passing in 913 suites.

Report generated by 🧪jest coverage report action from 60e20d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant