Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removeGiftCardCodes #2729

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add removeGiftCardCodes #2729

wants to merge 5 commits into from

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

SFAPI 2025-01 added a new mutation cartGiftCardCodesRemove. Update skeleton code to use it

WHAT is this pull request doing?

  • Update skeleton to use the new method removeGiftCardCodes from createCartHandler
  • Update docs on the new methods context.cart.removeGiftCardCodes and cartGiftCardCodesRemoveDefault
  • Bug: Add a couple gift card codes to cart, go to checkout and remove one of the gift card. When navigate back to shop, all the gift card code disappeared. After refresh, they come back.

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Jan 24, 2025

Oxygen deployed a preview of your hl-gift-card-remove branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment January 24, 2025 9:51 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment January 24, 2025 9:51 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment January 24, 2025 9:51 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment January 24, 2025 9:51 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment January 24, 2025 9:51 PM

Learn more about Hydrogen's GitHub integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants