Skip to content

Commit

Permalink
remove chromatic webfont removal (#11284)
Browse files Browse the repository at this point in the history
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Open it as a draft if it’s a work in progress
-->

### WHY are these changes introduced?
Relevant to #10104
Removing @sophschneider chromatic override because this
[PR](#11106) from @sam-b-rose
appears to have resolved the issue. (At the very least I can't replicate
the chromatic bug we were seeing after removal).

Per @alex-page' suggestion, we're going to as the kids say "Let it cook"
on main for a day, to see if chromatic fails. 🤞


### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
  • Loading branch information
gwyneplaine authored Dec 6, 2023
1 parent bf0593e commit cc127a5
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions polaris-react/.storybook/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ function StrictModeDecorator(Story, context) {
}

function AppProviderDecorator(Story, context) {
// Use system font in chromatic snapshots to avoid async font loading flakiness
if (isChromatic()) {
document.getElementById('inter-font-link').removeAttribute('href');
}

if (context.args.omitAppProvider) return <Story {...context} />;

return (
Expand Down

0 comments on commit cc127a5

Please sign in to comment.