Fix duplicate semicolon in built CSS styles #13179
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #13151
Came across this issue when trying to add tailwind v4 to a Shopify app template. Tailwind has switched CSS parsers in v4, and the vite plugin now errors if the app imports the Polaris styles with the error:
WHAT is this pull request doing?
This PR removes the semi-colons from the shopify-react mixins which cause the double semicolons in the final built CSS file. It also removes the semicolon from the shadow button primary variable from within polaris-tokens, which was causing an additional duplicate semicolon.
How to 🎩
To test with tailwind, you should:
./tailwindcss --input input.css --output output.css
N.B. It should be possible to recreate the error by parsing the styles.css before these changes were made (or in a separate existing project that uses shopify polaris):
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.md
with documentation changes