Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Ruby LSP v0.10.0 #149

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Upgrade to Ruby LSP v0.10.0 #149

merged 4 commits into from
Sep 12, 2023

Conversation

vinistock
Copy link
Member

Upgrade our requirement to v0.10.0 and fix the breaking change (the rename from @response to @_response in listeners).

@vinistock vinistock added the enhancement New feature or request label Sep 12, 2023
@vinistock vinistock added this to the 2023-Q3 milestone Sep 12, 2023
@vinistock vinistock self-assigned this Sep 12, 2023
@vinistock vinistock requested a review from a team as a code owner September 12, 2023 13:42
st0012
st0012 approved these changes Sep 12, 2023
View reviewed changes
ruby-lsp-rails.gemspec Show resolved Hide resolved
@vinistock vinistock merged commit 424bcf9 into main Sep 12, 2023
23 of 27 checks passed
@vinistock vinistock deleted the vs/upgrade_to_ruby_lsp_0_10 branch September 12, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan was automatically assigned from Shopify/ruby-dev-exp

@bitwise-aiden bitwise-aiden Awaiting requested review from bitwise-aiden bitwise-aiden was automatically assigned from Shopify/ruby-dev-exp

Assignees

@vinistock vinistock

Labels
enhancement New feature or request
Projects
None yet
Milestone
2023-Q3
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @st0012