Update for Rails 8 #479

andyw8 · 2024-10-09T19:49:48Z

Closes #468

There are two main things here:

I re-generated the dummy app with bundle exec rails plugin new then did some manual clean-up. There are more files than previously, but I think this is fine since otherwise we would need to clean these up on on every Rails update.
~~Due to Rails 8 changes, we now have to explictly eager load the routes.~~

I verified against code-db which is on Rails 7.2.

andyw8 · 2024-10-10T16:03:51Z

.rubocop.yml

@@ -10,7 +10,7 @@ AllCops:
  NewCops: disable
  SuggestExtensions: false
  Exclude:
-    - "test/dummy/db/**/*.rb"
+    - "test/dummy/**/*"


We shouldn't care about styling in the dummy app.

andyw8 · 2024-10-29T20:31:07Z

test/ruby_lsp_rails/code_lens_test.rb

@@ -315,7 +315,7 @@ def index
        uri = response[0].command.arguments.first.first

        assert_match("GET /users(.:format)", response[0].command.title)
-        assert_match("config/routes.rb#L4", uri)
+        assert_match("config/routes.rb#L3", uri)


Line number have changed because routes.rb no longer has # frozen_string_literal: true.

andyw8 · 2024-10-30T14:29:57Z

Gemfile

@@ -7,7 +7,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 gemspec

 gem "puma"
-gem "sqlite3", "< 2"
+gem "sqlite3"


v2 was causing an issue with Rails 7 previously

andyw8 · 2024-10-30T14:30:53Z

Gemfile

@@ -17,7 +17,7 @@ gem "rubocop-sorbet", "~> 0.8", require: false
 gem "sorbet-static-and-runtime", platforms: :ruby
 gem "tapioca", "~> 0.13", require: false, platforms: :ruby
 gem "psych", "~> 5.1", require: false
-gem "rails"
+gem "rails", "8.0.0.beta1"


We're up to RC2 now, but I will hold off updating until the proper release is out.

andyw8 · 2024-10-30T14:51:35Z

I've marked this as Ready for Review, however there are 2 tests which are failing only in CI and I cannot figure out why 😭 .

andyw8 · 2024-10-30T15:01:49Z

Ah, it's related to the config.eager_load = ENV["CI"].present? check in test.rb.

test/dummy/Rakefile

test/dummy/app/controllers/application_controller.rb

test/dummy/app/helpers/application_helper.rb

test/dummy/app/models/application_record.rb

test/dummy/bin/dev

test/dummy/config/environments/production.rb

test/dummy/config/environments/test.rb

test/dummy/config/initializers/inflections.rb

test/dummy/public/400.html

vinistock · 2024-10-30T17:28:45Z

.rubocop.yml

@@ -10,7 +10,7 @@ AllCops:
  NewCops: disable
  SuggestExtensions: false
  Exclude:
-    - "test/dummy/db/**/*.rb"
+    - "test/dummy/**/*"


andyw8 · 2024-10-30T18:04:55Z

My original intention was to have keep the dummy app as unchanged as possible, so as to minimize the work needed when regenerating it, but we can stick with the current approach.

andyw8 · 2024-10-30T18:11:56Z

test/ruby_lsp_rails/definition_test.rb

@@ -186,8 +186,8 @@ def baz; end
          URI::Generic.from_path(path: File.join(dummy_root, "config", "routes.rb")).to_s,
          response[0].uri,
        )
-        assert_equal(3, response[0].range.start.line)
-        assert_equal(3, response[0].range.end.line)
+        assert_equal(4, response[0].range.start.line)


Line numbers changed because the generated routes.rb has a new comment.

andyw8 · 2024-10-30T18:14:18Z

test/dummy/config/initializers/action_dispatch.rb

@@ -1,5 +0,0 @@
-# typed: true


(just noticed this was unintentionally removed, looking into whether to restore)

andyw8 · 2024-10-30T18:40:31Z

Re-verified against code-db and Core with the latest changes.

andyw8 added the chore Chore task label Oct 9, 2024

andyw8 force-pushed the andyw8/rails-8-beta branch 2 times, most recently from 4e7fb36 to b48958b Compare October 9, 2024 20:04

andyw8 marked this pull request as ready for review October 9, 2024 20:06

andyw8 requested a review from a team as a code owner October 9, 2024 20:06

andyw8 requested review from alexcrocha and vinistock October 9, 2024 20:06

andyw8 marked this pull request as draft October 9, 2024 20:08

andyw8 force-pushed the andyw8/rails-8-beta branch from b48958b to bd9dc2e Compare October 9, 2024 20:18

andyw8 commented Oct 10, 2024

View reviewed changes

andyw8 force-pushed the andyw8/rails-8-beta branch 3 times, most recently from 99aa3ed to 7d83ae8 Compare October 28, 2024 19:06

andyw8 changed the title ~~Update dummy app to Rails 8~~ Update for Rails 8 Oct 29, 2024

andyw8 commented Oct 29, 2024

View reviewed changes

andyw8 added 4 commits October 30, 2024 10:25

$ bundle update rails sqlite3

9756f9f

Ignore RuboCop for dummy app

284dc56

Re-generate dummy app using Rails 8.0.0.beta1

47369d2

Update tests due to line number change

ad5f781

andyw8 force-pushed the andyw8/rails-8-beta branch from 9aba385 to 0bdd5e1 Compare October 30, 2024 14:28

andyw8 commented Oct 30, 2024

View reviewed changes

andyw8 force-pushed the andyw8/rails-8-beta branch 2 times, most recently from 4653631 to 4eb2491 Compare October 30, 2024 14:50

andyw8 marked this pull request as ready for review October 30, 2024 14:50

Fixes for Rails 8

af30614

andyw8 force-pushed the andyw8/rails-8-beta branch from 4eb2491 to af30614 Compare October 30, 2024 15:24

vinistock reviewed Oct 30, 2024

View reviewed changes

andyw8 force-pushed the andyw8/rails-8-beta branch from ec3a221 to 7abfad3 Compare October 30, 2024 18:03

andyw8 added 5 commits October 30, 2024 14:09

Apply RuboCop to Dummy app

e605056

Fix line numbers

f298acc

Remove test/dummy/bin

f5cd208

Remove test/dummy/public

8be1ebe

Remove test/dummy/app/views/pwa

ef91dfb

andyw8 commented Oct 30, 2024

View reviewed changes

vinistock approved these changes Oct 30, 2024

View reviewed changes

andyw8 commented Oct 30, 2024

View reviewed changes

andyw8 force-pushed the andyw8/rails-8-beta branch from c96a17a to b384651 Compare October 30, 2024 18:28

andyw8 added 2 commits October 30, 2024 14:32

Restore initializer, remove server.rb changes

1ff2925

Lint

8fe81ac

andyw8 force-pushed the andyw8/rails-8-beta branch from b384651 to 8fe81ac Compare October 30, 2024 18:39

andyw8 enabled auto-merge (squash) October 30, 2024 18:40

andyw8 merged commit b5f4791 into main Oct 30, 2024
28 checks passed

andyw8 deleted the andyw8/rails-8-beta branch October 30, 2024 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for Rails 8 #479

Update for Rails 8 #479

andyw8 commented Oct 9, 2024 •

edited

Loading

andyw8 Oct 10, 2024

vinistock Oct 30, 2024

andyw8 Oct 29, 2024

andyw8 Oct 30, 2024

andyw8 Oct 30, 2024

andyw8 commented Oct 30, 2024

andyw8 commented Oct 30, 2024

vinistock Oct 30, 2024

andyw8 commented Oct 30, 2024

andyw8 Oct 30, 2024

andyw8 Oct 30, 2024

andyw8 commented Oct 30, 2024

Update for Rails 8 #479

Update for Rails 8 #479

Conversation

andyw8 commented Oct 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andyw8 commented Oct 30, 2024

andyw8 commented Oct 30, 2024

Choose a reason for hiding this comment

andyw8 commented Oct 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andyw8 commented Oct 30, 2024

andyw8 commented Oct 9, 2024 •

edited

Loading