Only invoke route.source_location if available #489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #492
Fix for #488
Since the Rails add-on is installed by default, while we don't aim to have every feature work on EOL versions of Rails, we still need to ensure we don't break. The
source_location
method only exists after 7.0.It would be nice to generalize a solution for handling which features are available based on Rails version. Rather than checking with
respond_to?
on the server side every time, we can avoid the request to the server completely if we keep some sort of feature dictionary. Something like