-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for checking for pending migrations and running them #503
Merged
vinistock
merged 1 commit into
main
from
11-01-add_support_for_checking_for_pending_migrations_and_running_them
Nov 4, 2024
Merged
Add support for checking for pending migrations and running them #503
vinistock
merged 1 commit into
main
from
11-01-add_support_for_checking_for_pending_migrations_and_running_them
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @vinistock and the rest of your teammates on Graphite |
vinistock
force-pushed
the
11-01-add_support_for_checking_for_pending_migrations_and_running_them
branch
2 times, most recently
from
November 1, 2024 18:37
dedae91
to
b26a4ca
Compare
st0012
reviewed
Nov 1, 2024
andyw8
reviewed
Nov 4, 2024
andyw8
reviewed
Nov 4, 2024
andyw8
approved these changes
Nov 4, 2024
st0012
approved these changes
Nov 4, 2024
vinistock
force-pushed
the
11-01-add_support_for_checking_for_pending_migrations_and_running_them
branch
from
November 4, 2024 21:58
b26a4ca
to
d9eb436
Compare
Merge activity
|
vinistock
deleted the
11-01-add_support_for_checking_for_pending_migrations_and_running_them
branch
November 4, 2024 22:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to check for pending migrations and run them through the Rails runner client.
For checking if something is pending, we use the Rails API directly, which raises if there are any pending migrations.
For running them, we can't do it in process. The code that runs migrations is not designed to be invoked repeatedly and uses
load
, which means that we could end up with a memory bloat. I usedOpen3.capture2
to run in a child process and grab the results.