369 completion for activerecord queries #526
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| response_builder: ResponseBuilders::CollectionResponseBuilder[T.any( | ||
| Interface::Location, Interface::LocationLink | ||
| )], |
There was a problem hiding this comment.
The type annotation for response_builder should be CollectionResponseBuilder[Interface::CompletionItem] to match the signature in create_completion_listener. The current type (Location and LocationLink) appears to have been copied from a different request handler.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| label_details: Interface::CompletionItemLabelDetails.new( | ||
| description: "Filter #{T.must(@node_context.call_node).receiver.name} records by #{column[0]}", | ||
| ), | ||
| text_edit: Interface::TextEdit.new(range: 0, new_text: "#{column[0]}:"), |
There was a problem hiding this comment.
The range parameter expects an Interface::Range object that specifies where in the document to insert the completion text. Using 0 as a value will cause incorrect insertion behavior. Consider constructing a proper range object based on the current cursor position or token boundaries.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
No description provided.