Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Repository admin UI #967

Closed
wants to merge 2 commits into from
Closed

Add Repository admin UI #967

wants to merge 2 commits into from

Conversation

indiebrain
Copy link
Contributor

@indiebrain indiebrain commented Dec 17, 2019 •
edited
Loading

Allow users to manage Repository objects

@casperisfine
Copy link
Contributor

After a quick review this looks mostly ok. However I'll hold onto merging this for now because it has little to no value until some feature is attached to repositories.

I suppose you plan to branch of this PR to implement #960 ?

@indiebrain
Copy link
Contributor Author

I suppose you plan to branch of this PR to implement #960 ?

Affirmative. I had hoped that separating the preliminary admin UI PR and our subsequent PRs to add the provisioning of "review stacks" would make the review process easier. We can certainly bundle these together if it makes it easier / more valuable to discuss all of this at once.

@casperisfine
Copy link
Contributor

We can certainly bundle these together if it makes it easier / more valuable to discuss all of this at once.

Nah, separate is fine. This PR is fairly straightforward, might as well have it out of the way.

@benlangfeld
Copy link
Contributor

Nah, separate is fine. This PR is fairly straightforward, might as well have it out of the way.

@casperisfine Does that mean you plan to merge this as is?

@casperisfine
Copy link
Contributor

Does that mean you plan to merge this as is?

No, sorry if it was confusing. By that I meant you can submit other PRs based on this one.

@indiebrain indiebrain force-pushed the add-repository-admin-ui branch from 39f6365 to 1615d44 Compare December 23, 2019 20:12
@benlangfeld benlangfeld mentioned this pull request Jan 7, 2020
Closed
@benlangfeld
Copy link
Contributor

This should be closed in favour of #976

@viniciusgama viniciusgama mentioned this pull request Jan 8, 2020
Closed
This was referenced Sep 2, 2020
Closed
Merged
@benlangfeld
Copy link
Contributor

This is superseded by #1102.

@benlangfeld benlangfeld mentioned this pull request Sep 25, 2020
Closed
@benlangfeld
Copy link
Contributor

Please close this one @indiebrain

@benlangfeld benlangfeld deleted the add-repository-admin-ui branch October 1, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indiebrain @casperisfine @benlangfeld