Fix failing local_vars test by translating post params #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
commented
Dec 19, 2024
egiurleo
force-pushed
the
emily/fix-381
branch
from
311b002 to
8145f58
Compare
egiurleo
force-pushed
the
emily/fix-381
branch
from
8145f58 to
8d8a9ed
Compare
egiurleo
changed the title
st0012
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #381
Opens #393, having to do with the handling of
**nilas a post param.Motivation
So uh... I think we (I) forgot that post params exist 😁
Test plan
See included automated tests.