Merge pull request #1794 from Shopify/uk-warn-for-unprocessable-compi…

…lers

Make unprocessable compilers a warning instead of an error

lib/tapioca/commands/abstract_dsl.rb

@@ -175,10 +175,11 @@ def constantize_compilers(compiler_names)
 
         unless unprocessable_compilers.empty?
           message = unprocessable_compilers.map do |name, _|
-            set_color("Error: Cannot find compiler '#{name}'", :red)
+            set_color("Warning: Cannot find compiler '#{name}'", :yellow)
           end.join("\n")
 
-          raise Thor::Error, message
+          say(message)
+          say("")
         end
 
         T.cast(compiler_map.values, T::Array[T.class_of(Tapioca::Dsl::Compiler)])

spec/tapioca/cli/dsl_spec.rb

@@ -1163,22 +1163,39 @@ module FooModule; end
           assert_success_status(result)
         end
 
-        it "errors if there are no matching compilers" do
-          result = @project.tapioca("dsl --only NonexistentCompiler")
+        it "warns if there are no matching compilers but continues processing" do
+          @project.write!("lib/post.rb", <<~RB)
+            require "smart_properties"
+
+            class Post
+              include SmartProperties
+              property :title, accepts: String
+            end
+          RB
+
+          result = @project.tapioca("dsl --only SmartProperties NonexistentCompiler")
 
           assert_equal(<<~OUT, result.out)
             Loading DSL extension classes... Done
             Loading Rails application... Done
             Loading DSL compiler classes... Done
             Compiling DSL RBI files...
 
-          OUT
+            Warning: Cannot find compiler 'NonexistentCompiler'
 
-          assert_equal(<<~ERROR, result.err)
-            Error: Cannot find compiler 'NonexistentCompiler'
-          ERROR
+                  create  sorbet/rbi/dsl/post.rbi
 
-          refute_success_status(result)
+            Done
+
+            Checking generated RBI files...  Done
+              No errors found
+
+            All operations performed in working directory.
+            Please review changes and commit them.
+          OUT
+
+          assert_empty_stderr(result)
+          assert_success_status(result)
         end
 
         it "must respect `exclude` option" do
@@ -1252,7 +1269,16 @@ def self.gather_constants
           assert_success_status(result)
         end
 
-        it "errors if there are no matching `exclude` compilers" do
+        it "warns if there are no matching `exclude` compilers but continues processing" do
+          @project.write!("lib/post.rb", <<~RB)
+            require "smart_properties"
+
+            class Post
+              include SmartProperties
+              property :title, accepts: String
+            end
+          RB
+
           result = @project.tapioca("dsl --exclude NonexistentCompiler")
 
           assert_equal(<<~OUT, result.out)
@@ -1261,13 +1287,21 @@ def self.gather_constants
             Loading DSL compiler classes... Done
             Compiling DSL RBI files...
 
-          OUT
+            Warning: Cannot find compiler 'NonexistentCompiler'
 
-          assert_equal(<<~ERROR, result.err)
-            Error: Cannot find compiler 'NonexistentCompiler'
-          ERROR
+                  create  sorbet/rbi/dsl/post.rbi
 
-          refute_success_status(result)
+            Done
+
+            Checking generated RBI files...  Done
+              No errors found
+
+            All operations performed in working directory.
+            Please review changes and commit them.
+          OUT
+
+          assert_empty_stderr(result)
+          assert_success_status(result)
         end
 
         it "must warn about reloaded constants and process only the newest one" do