Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin Table component types to RC #2623

Closed
wants to merge 20 commits into from

Conversation

billfienberg
Copy link
Contributor

@billfienberg billfienberg commented Feb 7, 2025

Important

If this PR gets merged, then #2624 should be closed.

TLDR

Generate Admin UI Extension types for Table components

Subtask of https://github.com/Shopify/admin-ui-foundations/issues/1514

Solution

Types generated by the generator added in https://github.com/Shopify/admin-ui-foundations/pull/1918

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

References

@billfienberg
Copy link
Contributor Author

billfienberg commented Feb 7, 2025

🎩 Tophat

See comment on web PR on web PR

@billfienberg
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @billfienberg! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/ui-extensions": "0.0.0-snapshot-20250207232320"

@billfienberg billfienberg changed the title Add admin Table component types Add admin Table component types to RC Feb 7, 2025
@billfienberg billfienberg marked this pull request as ready for review February 7, 2025 23:54
@frehner
Copy link

frehner commented Feb 14, 2025

closed by #2636

@frehner frehner closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants