-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add admin Table
component types to RC
#2623
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add version string into registration call
Add remote-dom components for Admin
Remove the generator.js script since it's been moved to a different repo
Update Admin components
Add stable Admin components
…tions Add definitions for TextArea and TextField
2 tasks
🎩 TophatSee comment on |
/snapit |
🫰✨ Thanks @billfienberg! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/ui-extensions": "0.0.0-snapshot-20250207232320" |
Table
component typesTable
component types to RC
2 tasks
5af64d8
to
3bffd1d
Compare
closed by #2636 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
If this PR gets merged, then #2624 should be closed.
TLDR
Generate Admin UI Extension types for
Table
componentsSubtask of https://github.com/Shopify/admin-ui-foundations/issues/1514
Solution
Types generated by the generator added in https://github.com/Shopify/admin-ui-foundations/pull/1918
Checklist
References
Table
component types to RC #2623Table
component types to internal #2624