Skip to content

Commit

Permalink
Merge branch 'main' into counter-at-edges
Browse files Browse the repository at this point in the history
  • Loading branch information
srikanthccv authored Feb 7, 2025
2 parents 275d3c0 + 37323a6 commit 4e1fa5a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ function RenderConnectionFields({
isConnectionParamsLoading ||
(!!connectionParams?.ingestion_url &&
!!connectionParams?.ingestion_key &&
!!connectionParams?.signoz_api_url)
!!connectionParams?.signoz_api_url &&
!!connectionParams?.signoz_api_key)
) {
return null;
}
Expand Down Expand Up @@ -48,6 +49,15 @@ function RenderConnectionFields({
<Input placeholder="Enter SigNoz API URL" disabled={isFormDisabled} />
</Form.Item>
)}
{!connectionParams?.signoz_api_key && (
<Form.Item
name="signoz_api_key"
label="SigNoz API KEY"
rules={[{ required: true, message: 'Please enter SigNoz API Key' }]}
>
<Input placeholder="Enter SigNoz API Key" disabled={isFormDisabled} />
</Form.Item>
)}
</Form.Item>
);
}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/hooks/integrations/aws/useIntegrationModal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export function useIntegrationModal({
ingestion_url: connectionParams?.ingestion_url || values.ingestion_url,
ingestion_key: connectionParams?.ingestion_key || values.ingestion_key,
signoz_api_url: connectionParams?.signoz_api_url || values.signoz_api_url,
signoz_api_key: connectionParams?.signoz_api_key || values.signoz_api_key,
},
account_config: {
regions: includeAllRegions ? ['all'] : selectedRegions,
Expand Down
1 change: 1 addition & 0 deletions frontend/src/types/api/integrations/aws.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export interface ConnectionParams {
ingestion_url?: string;
ingestion_key?: string;
signoz_api_url?: string;
signoz_api_key?: string;
}

export interface GenerateConnectionUrlPayload {
Expand Down

0 comments on commit 4e1fa5a

Please sign in to comment.