feat: implement deployments in k8s infra monitoring #6786
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 8afcbc8 in 1 minute and 34 seconds
More details
- Looked at
4746lines of code in31files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_WC8XBc3vcToAd1op
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/container/InfraMonitoringK8s/Deployments/utils.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 12b6670 in 26 seconds
More details
- Looked at
39lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/hooks/infraMonitoring/useGetK8sDeploymentsList.ts:37
- Draft comment:
The query key has been correctly updated toGET_DEPLOYMENT_LISTto reflect the new functionality for deployments. - Reason this comment was not posted:
Confidence changes required:0%
The change fromGET_HOST_LISTtoGET_DEPLOYMENT_LISTinuseGetK8sDeploymentsList.tsis correct and aligns with the new functionality for deployments.
2. frontend/src/hooks/infraMonitoring/useGetK8sNodesList.ts:37
- Draft comment:
The query key has been correctly updated toGET_NODE_LISTto reflect the functionality for nodes. - Reason this comment was not posted:
Confidence changes required:0%
The change fromGET_HOST_LISTtoGET_NODE_LISTinuseGetK8sNodesList.tsis correct and aligns with the functionality for nodes.
Workflow ID: wflow_L2HWLzwt0ykQ60Dq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 469ea25 in 48 seconds
More details
- Looked at
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Deployments/utils.tsx:234
- Draft comment:
Ensure that the new colorColor.BG_SLATE_400for the Tag component maintains sufficient contrast for accessibility. Consider using a tool to verify color contrast ratios. - Reason this comment was not posted:
Confidence changes required:50%
The color change for the Tag component is appropriate, but it's important to ensure that the new color is accessible and maintains good contrast.
Workflow ID: wflow_2OK9ocmREA9VKhxP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
Implementation of deployments entity for Infra Monitoring
Related Issues / PR's
N/A
Screenshots
Affected Areas and Manually Tested Areas
Infra Monitoring section
Important
Implement Kubernetes deployments monitoring in infrastructure monitoring with new API, UI components, and query handling.
getK8sDeploymentsListingetK8sDeploymentsList.tsto fetch deployment data.useGetK8sDeploymentsListhook inuseGetK8sDeploymentsList.tsfor querying deployment data.K8sDeploymentsList.tsxfor listing deployments with pagination and sorting.DeploymentDetails.tsxfor detailed view of a deployment with tabs for metrics, logs, traces, and events.K8sDeploymentsList.styles.scssandDeploymentDetails.styles.scss.constants.tsfor deployments, logs, events, and traces.reactQueryKeys.tswithGET_DEPLOYMENT_LISTkey.InfraMonitoringK8s.tsxto include deployments in the monitoring dashboard.This description was created by
for 469ea25. It will automatically update as commits are pushed.