fix: the unknown blank height in spanTree #6794
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues #6793
Screenshots
Before:
After fixed:
Important
Fixes unknown blank height in span tree by removing static
levels
property and calculating dynamically inTraceFlameGraph
.levels
property fromITraceMetaData
inGanttChart
,Timeline
, andTraceDetail
components.TraceFlameGraph
to calculatelevels
dynamically usinggetTreeLevelsCount()
.getTreeLevelsCount
usage fromTraceDetail
and moves it toTraceFlameGraph
.getSpanTreeMetadata
to excludelevels
calculation.levels
fromgetSpanTreeMetadata
return type and related interfaces.This description was created by for 8c35934. It will automatically update as commits are pushed.