Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the unknown blank height in spanTree #6794

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smbera
Copy link

@smbera smbera commented Jan 10, 2025

Summary

Related Issues #6793

Screenshots

Before:

image

After fixed:

image


Important

Fixes unknown blank height in span tree by removing static levels property and calculating dynamically in TraceFlameGraph.

  • Behavior:
    • Removes levels property from ITraceMetaData in GanttChart, Timeline, and TraceDetail components.
    • Adjusts TraceFlameGraph to calculate levels dynamically using getTreeLevelsCount().
  • Functions:
    • Removes getTreeLevelsCount usage from TraceDetail and moves it to TraceFlameGraph.
    • Updates getSpanTreeMetadata to exclude levels calculation.
  • Misc:
    • Removes levels from getSpanTreeMetadata return type and related interfaces.

This description was created by Ellipsis for 8c35934. It will automatically update as commits are pushed.

@smbera smbera requested a review from YounixM as a code owner January 10, 2025 03:30
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8c35934 in 47 seconds

More details
  • Looked at 110 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. frontend/src/container/GantChart/index.tsx:73
  • Draft comment:
    The 'levels' property has been removed from the ITraceMetaData interface. Ensure that any logic relying on 'levels' is updated to use the new approach, such as using the getTreeLevelsCount function where necessary.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. frontend/src/container/TraceDetail/index.tsx:178
  • Draft comment:
    The 'levels' property has been removed from the ITraceMetaData interface. Ensure that any logic relying on 'levels' is updated to use the new approach, such as using the getTreeLevelsCount function where necessary.
  • Reason this comment was not posted:
    Marked as duplicate.
3. frontend/src/utils/getSpanTreeMetadata.ts:43
  • Draft comment:
    The 'levels' property has been removed from the ITraceMetaData interface. Ensure that any logic relying on 'levels' is updated to use the new approach, such as using the getTreeLevelsCount function where necessary.
  • Reason this comment was not posted:
    Marked as duplicate.
4. frontend/src/container/GantChart/index.tsx:73
  • Draft comment:
    Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This applies to lines 45 and 47.
  • Reason this comment was not posted:
    Comment was on unchanged code.
5. frontend/src/container/Timeline/index.tsx:102
  • Draft comment:
    Use design tokens or predefined color constants instead of hardcoding color values. This applies to lines 67, 82, and 89.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
6. frontend/src/container/TraceDetail/index.tsx:38
  • Draft comment:
    Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_q9eT44w9pUEnjWk0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant