-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update logs in infra monitoring for analytics #6994
Conversation
bfa68c0
to
e12f6f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to bfa68c0 in 1 minute and 22 seconds
More details
- Looked at
1053
lines of code in18
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Volumes/K8sVolumesList.tsx:430
- Draft comment:
Ensure consistency in log event naming. Consider using 'Infra Monitoring: K8s volumes list group by changed' for consistency with other similar log events. - Reason this comment was not posted:
Confidence changes required:50%
The logEvent function is used consistently across the codebase to track user interactions and state changes. However, there is a minor inconsistency in the naming of the log event for the "group by" change in the Volumes list. It should be consistent with other similar log events.
Workflow ID: wflow_GA0OHQn3gpjN8GzH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
e12f6f0
to
80943ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 80943ce in 1 minute and 6 seconds
More details
- Looked at
1053
lines of code in18
files - Skipped
0
files when reviewing. - Skipped posting
6
drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Volumes/K8sVolumesList.tsx:160
- Draft comment:
BUG: The aggregate key is fetched using K8sCategory.NODES. For a volumes list, the aggregateAttribute should use K8sCategory.VOLUMES. Similarly, the third parameter (infraMonitoringEntity) should be K8sCategory.VOLUMES. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. frontend/src/container/InfraMonitoringK8s/Volumes/K8sVolumesList.tsx:481
- Draft comment:
BUG: The K8sHeader component is passed entity={K8sCategory.NODES} which is incorrect for a volumes list. It should be set to K8sCategory.VOLUMES. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. frontend/src/container/InfraMonitoringK8s/Namespaces/NamespaceDetails/NamespaceDetails.tsx:407
- Draft comment:
Avoid inline styles in the Drawer; move style={{overscrollBehavior: 'contain', background: isDarkMode ? Color.BG_INK_400 : Color.BG_VANILLA_100}} to a CSS class for better theming consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. frontend/src/container/InfraMonitoringK8s/Pods/PodDetails/PodDetails.tsx:207
- Draft comment:
The useCallback for handleTimeChange uses variables like selectedView without including them in the dependency array. This may lead to stale closures. Consider adding all external dependencies (e.g. selectedView, maybe selectedTime) or document why they are excluded. - Reason this comment was not posted:
Comment was on unchanged code.
5. Multiple Files:1
- Draft comment:
Several components disable the 'react-hooks/exhaustive-deps' lint rule. Please review if this is intentional. Missing dependencies in useCallback and useEffect hooks can lead to unexpected stale values. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. frontend/src/container/InfraMonitoringK8s/StatefulSets/StatefulSetDetails/StatefulSetDetails.tsx:200
- Draft comment:
Ensure that logEvent calls consistently include meaningful context (e.g., using statefulSet?.statefulSetName) so that analytics capture the correct identifiers. The naming seems mostly consistent but double-check that all entities use the proper properties. - Reason this comment was not posted:
Confidence changes required:30%
None
Workflow ID: wflow_hGdutJpqcejAsOPK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Updated existing logs and added some new ones in infra monitoring
Related Issues / PR's
Fixes #6893
Screenshots
NA
Affected Areas and Manually Tested Areas
Infra Monitoring K8s
Important
Enhance logging in Kubernetes infra monitoring for analytics by adding detailed log events for user interactions across various components.
ClusterDetails.tsx
,DaemonSetDetails.tsx
,DeploymentDetails.tsx
,JobDetails.tsx
,NamespaceDetails.tsx
,NodeDetails.tsx
,PodDetails.tsx
,StatefulSetDetails.tsx
.K8sClustersList.tsx
,K8sDaemonSetsList.tsx
,K8sDeploymentsList.tsx
,K8sJobsList.tsx
,K8sNamespacesList.tsx
,K8sNodesList.tsx
,K8sPodLists.tsx
,K8sStatefulSetsList.tsx
,K8sVolumesList.tsx
.K8sClustersList.tsx
,K8sDaemonSetsList.tsx
,K8sDeploymentsList.tsx
,K8sJobsList.tsx
,K8sNamespacesList.tsx
,K8sNodesList.tsx
,K8sPodLists.tsx
,K8sStatefulSetsList.tsx
,K8sVolumesList.tsx
.K8sClustersList.tsx
,K8sDaemonSetsList.tsx
,K8sDeploymentsList.tsx
,K8sJobsList.tsx
,K8sNamespacesList.tsx
,K8sNodesList.tsx
,K8sPodLists.tsx
,K8sStatefulSetsList.tsx
,K8sVolumesList.tsx
.numberOfPages
calculation in several list components to support pagination logging.This description was created by for 80943ce. It will automatically update as commits are pushed.