Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add_pats): fix type of column #7026

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix(add_pats): fix type of column #7026

merged 1 commit into from
Feb 5, 2025

Conversation

grandwizard28
Copy link
Collaborator

@grandwizard28 grandwizard28 commented Feb 4, 2025

Summary

Fix type of column in ALTER query. We missed this because CREATE TABLE creates the column and then the ALTER query is a no-op. Raising this PR for our future effort of integrating other sql databases.


Important

Fixes column type in 009_add_pats.go for role in personal_access_tokens from test to TEXT.

  • SQL Migration:
    • Fixes column type in 009_add_pats.go for role in personal_access_tokens from test to TEXT.

This description was created by Ellipsis for 67723c9. It will automatically update as commits are pushed.

@github-actions github-actions bot added the bug Something isn't working label Feb 4, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 67723c9 in 28 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pkg/sqlmigration/009_add_pats.go:62
  • Draft comment:
    Fix correctly updates column type from 'test' to 'TEXT', now consistent with CREATE TABLE. Ensure this aligns with existing data constraints.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. pkg/sqlmigration/009_add_pats.go:62
  • Draft comment:
    Fixed typo: changed 'test' to 'TEXT' to correctly define the column type.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_uli7LG9ge03e5hax


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@grandwizard28 grandwizard28 merged commit 0359992 into main Feb 5, 2025
17 checks passed
@grandwizard28 grandwizard28 deleted the fix-migration-name branch February 5, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants