Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update win_security_susp_sdelete.yml #5125

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Conversation

randomaccess3
Copy link
Contributor

@randomaccess3 randomaccess3 commented Dec 13, 2024

Summary of the Pull Request

Change in rule name and exceptions as an interaction with a file extension .AAA or .zzz is not necessarily related to sdelete. Sdelete overwrites filenames and will have these extensions but not guaranteed to be a clear indicator.

Changelog

Changed title
Added another exception

Example Log Event

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels Dec 13, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @randomaccess3 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

@frack113
Copy link
Member

Hi,

Can you fill the PR template please.
Thanks

@frack113 frack113 added the 2nd Review Needed PR need a second approval label Dec 14, 2024
@nasbench nasbench merged commit a290d22 into SigmaHQ:master Dec 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2nd Review Needed PR need a second approval Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants