Skip to content

Commit

Permalink
[RAPPS] DelRegEmpty instruction should be best-effort, don't propagat…
Browse files Browse the repository at this point in the history
…e any errors (reactos#6860)

DelRegEmpty exists to clean up "company" registry parent keys. If another application is writing to the key at the same time as we are gently trying to remove it, our uninstaller should ignore any errors.
  • Loading branch information
whindsaks authored May 11, 2024
1 parent a3d9d0e commit 5db69da
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/applications/rapps/geninst.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ UninstallThread(LPVOID Parameter)
if (op == UNOP_REGKEY)
err = key.RecurseDeleteKey(tmp);
else if (RegKeyHasValues(hKey, str, wowsam) == S_FALSE)
err = key.DeleteSubKey(tmp);
key.DeleteSubKey(tmp); // DelRegEmpty ignores errors
}
switch(err)
{
Expand Down

0 comments on commit 5db69da

Please sign in to comment.