Fix: other vessels data updating beyond timeout for their data #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract secondsSinceVesselUpdate and add a check for timestamp being there.
Move the check for other vessel's position earlier so that no deltas are emitted if the position is stale. Fixes #149.
Add logic that explicitly sets - distanceToSelf - closestApproach to null if the other vessel's data has timed out. Null is sent only once, so that we don't keep the vessel's data updated and thus prevent server removing its data.
panaaj
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
closestApproachanddistanceToSelfonce for vessels that have timed outFixes #149