SK Server Admin UI Activity View Update #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The headings could be "heavier", so that you can tell that they are headings for the list below. Don't know how relevant in real life, but if there's no plugin activity the heading looks a little oprhaned 
|
|
Minor nuisance, but now all Connections link to Connections page, even if just some of them can be configured there. |
|
Pretty much all fixed now from activity view. |
|
Could #1146 also be looked at in this PR? |
|
Related but independent, better kep separate. But I hear you… |
|
Duplicated/similar code parts are removed. |
|
Fixes and optimizations for Dashboard starts to be finalized for now. If still something need to be changed or added ok, otherwise ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to
Connection activityview on SK Admin UI.Currently activity view is mixed list of
ConnectionsandPluginsactivities and list is not sorted at all.Update will split activities to
ConnectionsandPluginsand sort list in alphabetic order.Example view:
