Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Seatalk1 on Raspberry Pi 5 #1779

Merged
merged 8 commits into from
Aug 29, 2024

Conversation

astuder
Copy link
Contributor

@astuder astuder commented Aug 23, 2024

As discussed in issue #1658 the existing integration of Seatalk1 does not work for Raspberry Pi 5 as the underlying Python library doesn't support the Raspberry Pi 5.

This pull-request uses the gpiod Python library to implement the functionality. This library is also supported by older versions of Raspberry Pi OS and hardware, so it could eventually replace pigpio.

I added a new field GPIO Library to the connection dialog to select between gpiod and pigpio.

I tested this pull request on a Raspberry Pi 5.

The standalone Python script (available here) was successfully tested on Raspberry Pi 3, 4 and 5, running Raspberry Pi OS Bookworm and Bullseye.

Copy link
Member

@tkurki tkurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the approach is sound and not being a Pythonist nor a Seatalk user I don't have much to comment on here.

Let's try to get the doc update in 4664938 included in this PR, makes for a little nicer Release Notes.

@astuder
Copy link
Contributor Author

astuder commented Aug 28, 2024

merged documentation updates provided by @sailoog

@tkurki
Copy link
Member

tkurki commented Aug 28, 2024

Please npm run format the ui code, see the failed test.

@astuder
Copy link
Contributor Author

astuder commented Aug 28, 2024

done

@tkurki tkurki merged commit dfd5f93 into SignalK:master Aug 29, 2024
4 checks passed
@astuder astuder deleted the gpiod-seatalk branch September 10, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants