Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Seatalk1: Auto-detect gpiochip for Raspberry Pi 5 #1789

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

astuder
Copy link
Contributor

@astuder astuder commented Sep 11, 2024

Fixes issue #1788 by automatically detecting the correct gpiochip device for use with gpiod.

Please await feedback from @sailoog before merging as I don't have actual Seatalk1 hardware for testing.

@astuder astuder changed the title Seatalk1: Auto-detect gpiochip for Raspberry Pi 5 fix: Seatalk1: Auto-detect gpiochip for Raspberry Pi 5 Sep 11, 2024
@sailoog
Copy link
Contributor

sailoog commented Sep 11, 2024

Tested on Raspberry 4 and 5, kernel 6.6.47 (stable), gpiod 1 and 2. No issues.

@tkurki
Copy link
Member

tkurki commented Sep 11, 2024

@astuder fyi you can create PRs in draft mode => merge buttons are disabled, so harder to merge prematurely by accident.

@astuder
Copy link
Contributor Author

astuder commented Sep 11, 2024

Sorry, I didn't see the "draft mode" feature.

Anyways, looks like we're good from the testing side.

@tkurki tkurki added the feature label Sep 12, 2024
@tkurki tkurki merged commit b240098 into SignalK:master Sep 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants