-
Notifications
You must be signed in to change notification settings - Fork 44.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(builder): Aligning error and loading for NextJS best practices (#…
…7894) * feat(builder): Add skeleton loading components for Monitor views Introduce skeleton components for Agents, Flow Runs List, and Flow Runs Status sections to enhance loading state indication. These components help improve user experience by visually outlining content placeholders while data is being fetched. * feat(builder): Leveraging NextJS's error boundary with error.tsx Replace the basic error page with a more detailed and interactive error component. The new component includes a retry option, a link to the homepage, and logs the error details to the console. It also aligns with NextJS standards ---------
- Loading branch information
1 parent
6066990
commit e17ea22
Showing
6 changed files
with
139 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
"use client"; | ||
|
||
import { useEffect } from "react"; | ||
import { IconCircleAlert } from "@/components/ui/icons"; | ||
import { Button } from "@/components/ui/button"; | ||
import Link from "next/link"; | ||
|
||
export default function Error({ | ||
error, | ||
reset, | ||
}: { | ||
error: Error & { digest?: string }; | ||
reset: () => void; | ||
}) { | ||
useEffect(() => { | ||
console.error(error); | ||
}, [error]); | ||
|
||
return ( | ||
<div className="fixed inset-0 flex items-center justify-center bg-background"> | ||
<div className="w-full max-w-md px-4 text-center sm:px-6"> | ||
<div className="mx-auto flex size-12 items-center justify-center rounded-full bg-muted"> | ||
<IconCircleAlert className="size-10" /> | ||
</div> | ||
<h1 className="mt-8 text-2xl font-bold tracking-tight text-foreground"> | ||
Oops, something went wrong! | ||
</h1> | ||
<p className="mt-4 text-muted-foreground"> | ||
We're sorry, but an unexpected error has occurred. Please try again | ||
later or contact support if the issue persists. | ||
</p> | ||
<div className="mt-6 flex flex-row justify-center gap-4"> | ||
<Button onClick={reset} variant="outline"> | ||
Retry | ||
</Button> | ||
<Button> | ||
<Link href="/">Go to Homepage</Link> | ||
</Button> | ||
</div> | ||
</div> | ||
</div> | ||
); | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import AgentFlowListSkeleton from "@/components/monitor/skeletons/AgentFlowListSkeleton"; | ||
import React from "react"; | ||
import FlowRunsListSkeleton from "@/components/monitor/skeletons/FlowRunsListSkeleton"; | ||
import FlowRunsStatusSkeleton from "@/components/monitor/skeletons/FlowRunsStatusSkeleton"; | ||
|
||
export default function MonitorLoadingSkeleton() { | ||
return ( | ||
<div className="space-y-4 p-4"> | ||
<div className="grid grid-cols-1 gap-4 md:grid-cols-3"> | ||
{/* Agents Section */} | ||
<AgentFlowListSkeleton /> | ||
|
||
{/* Runs Section */} | ||
<FlowRunsListSkeleton /> | ||
|
||
{/* Stats Section */} | ||
<FlowRunsStatusSkeleton /> | ||
</div> | ||
</div> | ||
); | ||
} |
24 changes: 24 additions & 0 deletions
24
rnd/autogpt_builder/src/components/monitor/skeletons/AgentFlowListSkeleton.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
export default function AgentsFlowListSkeleton() { | ||
return ( | ||
<div className="mx-auto max-w-4xl p-4"> | ||
<div className="mb-4 flex items-center justify-between"> | ||
<h1 className="text-2xl font-bold">Agents</h1> | ||
<div className="h-10 w-24 animate-pulse rounded bg-gray-200"></div> | ||
</div> | ||
<div className="rounded-lg bg-white p-4 shadow"> | ||
<div className="mb-4 grid grid-cols-3 gap-4 font-medium text-gray-500"> | ||
<div>Name</div> | ||
<div># of runs</div> | ||
<div>Last run</div> | ||
</div> | ||
{[...Array(3)].map((_, index) => ( | ||
<div key={index} className="mb-4 grid grid-cols-3 gap-4"> | ||
<div className="h-6 animate-pulse rounded bg-gray-200"></div> | ||
<div className="h-6 animate-pulse rounded bg-gray-200"></div> | ||
<div className="h-6 animate-pulse rounded bg-gray-200"></div> | ||
</div> | ||
))} | ||
</div> | ||
</div> | ||
); | ||
} |
23 changes: 23 additions & 0 deletions
23
rnd/autogpt_builder/src/components/monitor/skeletons/FlowRunsListSkeleton.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
export default function FlowRunsListSkeleton() { | ||
return ( | ||
<div className="mx-auto max-w-4xl p-4"> | ||
<div className="rounded-lg bg-white p-4 shadow"> | ||
<h2 className="mb-4 text-xl font-semibold">Runs</h2> | ||
<div className="mb-4 grid grid-cols-4 gap-4 text-sm font-medium text-gray-500"> | ||
<div>Agent</div> | ||
<div>Started</div> | ||
<div>Status</div> | ||
<div>Duration</div> | ||
</div> | ||
{[...Array(4)].map((_, index) => ( | ||
<div key={index} className="mb-4 grid grid-cols-4 gap-4"> | ||
<div className="h-5 animate-pulse rounded bg-gray-200"></div> | ||
<div className="h-5 animate-pulse rounded bg-gray-200"></div> | ||
<div className="h-5 animate-pulse rounded bg-gray-200"></div> | ||
<div className="h-5 animate-pulse rounded bg-gray-200"></div> | ||
</div> | ||
))} | ||
</div> | ||
</div> | ||
); | ||
} |
28 changes: 28 additions & 0 deletions
28
rnd/autogpt_builder/src/components/monitor/skeletons/FlowRunsStatusSkeleton.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
export default function FlowRunsStatusSkeleton() { | ||
return ( | ||
<div className="mx-auto max-w-4xl p-4"> | ||
<div className="rounded-lg bg-white p-4 shadow"> | ||
<div className="mb-6 flex items-center justify-between"> | ||
<h2 className="text-xl font-semibold">Stats</h2> | ||
<div className="flex space-x-2"> | ||
{["2h", "8h", "24h", "7d", "Custom", "All"].map((btn) => ( | ||
<div | ||
key={btn} | ||
className="h-8 w-16 animate-pulse rounded bg-gray-200" | ||
></div> | ||
))} | ||
</div> | ||
</div> | ||
|
||
{/* Placeholder for the line chart */} | ||
<div className="mb-6 h-64 w-full animate-pulse rounded bg-gray-200"></div> | ||
|
||
{/* Placeholders for total runs and total run time */} | ||
<div className="space-y-2"> | ||
<div className="h-6 w-1/3 animate-pulse rounded bg-gray-200"></div> | ||
<div className="h-6 w-1/2 animate-pulse rounded bg-gray-200"></div> | ||
</div> | ||
</div> | ||
</div> | ||
); | ||
} |