-
Notifications
You must be signed in to change notification settings - Fork 44.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(agent, forge): Move relevant tests from autogpt
to forge
#7175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create `BaseConfig` in `forge`
github-actions
bot
added
the
conflicts
Automatically applied to PRs with merge conflicts
label
May 29, 2024
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
added
documentation
Improvements or additions to documentation
Classic AutoGPT Agent
Forge
Classic Benchmark
size/xl
and removed
conflicts
Automatically applied to PRs with merge conflicts
labels
May 29, 2024
β Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
conflicts
Automatically applied to PRs with merge conflicts
label
May 29, 2024
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
kcze
changed the title
refactor(agent, forge): Move relevant tests from
refactor(agent, forge): Outdated, move relevant tests from Jun 22, 2024
autogpt
to forge
autogpt
to forge
kcze
changed the title
refactor(agent, forge): Outdated, move relevant tests from
refactor(agent, forge): Move relevant tests from Jun 22, 2024
autogpt
to forge
autogpt
to forge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Classic AutoGPT Agent
Classic Benchmark
conflicts
Automatically applied to PRs with merge conflicts
documentation
Improvements or additions to documentation
Forge
size/xl
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OUTDATED, superseded by #7247
Background
After refactor #7106, due to coupling tests that should had been moved to
forge
stayed inautogpt
.Changes ποΈ
Moved relevant tests from
autogpt/tests
to appropiate directories:autogpt/tests/unit/test_gcs_file_storage.py
βforge/file_storage/test_gcs_file_storage.py
autogpt/tests/unit/test_local_file_storage.py
βforge/file_storage/test_local_file_storage.py
autogpt/tests/unit/test_s3_file_storage.py
βforge/file_storage/test_s3_file_storage.py
autogpt/tests/unit/test_json.py
βforge/json/test_parsing.py
autogpt/tests/unit/test_logs.py
βforge/logging/test_utils.py
autogpt/tests/unit/test_text_file_parsers.py
βforge/utils/test_file_operations.py
autogpt/tests/unit/test_url_validation.py
βforge/utils/test_url_validator.py
PR Quality Scorecard β¨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance? β+10 pts