Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forge): Add google-api-python-client-stubs and fix type error #7303

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jul 3, 2024

Changes 🏗️

  • Add google-api-python-client-stubs dev dependency
  • Add version specification to google-api-python-client dependency
  • Fix type error (by ignoring it) in forge/components/web/search.py

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@Pwuts Pwuts requested a review from a team as a code owner July 3, 2024 00:23
@Pwuts Pwuts requested review from Torantulino and aarushik93 and removed request for a team July 3, 2024 00:23
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit e114160
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/668499fd1c96450008f36f42

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.54%. Comparing base (7cb4d4a) to head (e114160).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7303      +/-   ##
==========================================
- Coverage   28.00%   25.54%   -2.46%     
==========================================
  Files         102       80      -22     
  Lines        6557     4663    -1894     
  Branches      961      631     -330     
==========================================
- Hits         1836     1191     -645     
+ Misses       4640     3405    -1235     
+ Partials       81       67      -14     
Flag Coverage Δ
Linux 25.54% <ø> (-2.46%) ⬇️
Windows 25.53% <ø> (-4.58%) ⬇️
agbenchmark ?
autogpt-agent 35.91% <ø> (ø)
forge 21.68% <ø> (ø)
macOS 25.54% <ø> (-2.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pwuts Pwuts merged commit 7415e24 into master Jul 3, 2024
28 of 29 checks passed
@Pwuts Pwuts deleted the reinier/open-1350-fix-autogpt-type-checking-error branch July 3, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix autogpt type checking error
3 participants