feat(server): REST API and WS API now use env vars for host and port.

[twinsant]

User description
Background

Previous versions used hard-coded settings for the server's host and port, which was inconvenient during development
Changes 🏗️

Added host and port settings to the .env file

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 Security concerns Potential exposure to unauthorized access: The REST API server is configured to listen on all network interfaces (0.0.0.0) by default. This configuration could potentially expose the server to unauthorized access from any network interface if not properly secured. It's recommended to use a more restrictive default, such as 127.0.0.1, for local development, and only use 0.0.0.0 in controlled environments where it's necessary and secure.

⚡ Key issues to review Potential Security Risk The server is set to listen on all network interfaces (0.0.0.0) by default. This might expose the server to unnecessary risks if not properly secured. Configuration Consistency The .env.example file sets default values for AP_SERVER_PORT and WS_SERVER_PORT, but these might conflict with the PORT environment variable set in the Dockerfile.

[netlify]

✅ Deploy Preview for auto-gpt-docs canceled.

Name	Link
🔨 Latest commit	46b8f9a
🔍 Latest deploy log	https://app.netlify.com/sites/auto-gpt-docs/deploys/66f3571948d52a000859c92d

[kcze]

nit for consistency

Suggested change

	AP_SERVER_HOST="0.0.0.0"
	AP_SERVER_PORT="8000"
	# WS API
	WS_SERVER_HOST="0.0.0.0"
	WS_SERVER_PORT="8001"
	AP_SERVER_HOST=localhost
	AP_SERVER_PORT=8000
	# WS API
	WS_SERVER_HOST=localhost
	WS_SERVER_PORT=8001

edit: I realised that 0.0.0.0 is not the same as localhost but quote marks can be removed nonetheless.

[kcze]

I think it would be good if @aarushik93 and @majdyz looked at this as well.

[github-actions]

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

[Pwuts]

Since #8008, the ports are configurable:

AutoGPT/rnd/autogpt_server/autogpt_server/util/settings.py

Lines 75 to 88 in f8f6bbc

	execution_manager_port: int = Field(
	default=8002,
	description="The port for execution manager daemon to run on",
	)
	execution_scheduler_port: int = Field(
	default=8003,
	description="The port for execution scheduler daemon to run on",
	)
	agent_server_port: int = Field(
	default=8004,
	description="The port for agent server daemon to run on",
	)

These settings can be used like AGENT_SERVER_PORT=8123.

Do you really need the host to be separately configurable?

[twinsant]

Since #8008, the ports are configurable:

AutoGPT/rnd/autogpt_server/autogpt_server/util/settings.py

Lines 75 to 88 in f8f6bbc

	execution_manager_port: int = Field(
	default=8002,
	description="The port for execution manager daemon to run on",
	)
	execution_scheduler_port: int = Field(
	default=8003,
	description="The port for execution scheduler daemon to run on",
	)
	agent_server_port: int = Field(
	default=8004,
	description="The port for agent server daemon to run on",
	)

These settings can be used like AGENT_SERVER_PORT=8123.

Do you really need the host to be separately configurable?

Yes, on production server, we need listen to the specific internal host for security reasons, so it's better to config host as a setting.

[twinsant]

Waiting for a loooooong time....

[majdyz]

@twinsant That config file is already env-var configurable, you can use the caps too.
e.g:
https://github.com/Significant-Gravitas/AutoGPT/blob/198a1048e8b8f365180415dfc0fb02818111be87/autogpt_platform/backend/backend/util/settings.py#L103C5-L103C19

If you want to change the Agent API port from 8006 to 8009, you can set:
AGENT_API_PORT=8009

[majdyz]

Subsequently, you can utilize the same convention to introduce host configuration.
The current PR is unfortunately conflicting & feature-clashing with the existing settings.py feature, would you mind rebasing your change to adapt to the latest code?

[majdyz]

@twinsant #8143 If you don't mind adapting your code to this and see if it matches your requirement, I can close my PR and use yours.

[twinsant]

@twinsant #8143 If you don't mind adapting your code to this and see if it matches your requirement, I can close my PR and use yours.

fine, will improve on your changes.