Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(rnd): Move to the PG within Supabase #8085

Merged
merged 8 commits into from
Sep 23, 2024
Merged

tweak(rnd): Move to the PG within Supabase #8085

merged 8 commits into from
Sep 23, 2024

Conversation

aarushik93
Copy link
Contributor

@aarushik93 aarushik93 commented Sep 18, 2024 •
edited
Loading

Background

Moving to using only one DB locally

Changes 🏗️

Updated the DB Urls in docker compose to use supabase

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@aarushik93 aarushik93 requested a review from a team as a code owner September 18, 2024 09:14
@aarushik93 aarushik93 requested review from Pwuts and Torantulino and removed request for a team September 18, 2024 09:14
@qodo-merge-pro Qodo Merge Pro
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 Security concerns

Sensitive information exposure:
The PR includes changes to database connection strings that contain passwords. While these are typically not committed to version control, extra caution should be taken to ensure these are not accidentally exposed in public repositories or logs. Consider using environment variables or secrets management for sensitive information.

⚡ Key issues to review

Configuration Change
The DATABASE_URL environment variable has been updated across multiple services to use a new username, password, and host. This change needs to be reviewed to ensure it's consistent and correct for all services.

Schema Addition
A schema parameter has been added to the DATABASE_URL for the market service. This change should be reviewed to confirm if it's intentional and if other services require similar updates.

@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit f150ce7
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66f166415dc2f800080445e9

majdyz
majdyz previously approved these changes Sep 18, 2024
View reviewed changes
Swiftyos
Swiftyos previously approved these changes Sep 19, 2024
View reviewed changes
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@Swiftyos
Merge remote-tracking branch 'origin/master' into aarushikansal/secrt…
53933e3 
…-869-migrate-existing-pg-to-supabase-pg-locally
@Swiftyos
remove postgres and bind supabase port
bd7c7d9
@Swiftyos
Updated setup
2f116f4 
- Switched db name to postgres to work with prisma studio
- Added platform schema
- Added Market-migartions
- bound prisma studio port
@Swiftyos Swiftyos dismissed stale reviews from majdyz and themself via 2f116f4 September 23, 2024 09:59
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Sep 23, 2024
Swiftyos
Swiftyos previously approved these changes Sep 23, 2024
View reviewed changes
@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/l and removed size/m labels Sep 23, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 23, 2024
@aarushik93 aarushik93 merged commit 88e278b into master Sep 23, 2024
9 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/secrt-869-migrate-existing-pg-to-supabase-pg-locally branch September 23, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majdyz majdyz majdyz left review comments

@Swiftyos Swiftyos Swiftyos left review comments

@Pwuts Pwuts Awaiting requested review from Pwuts Pwuts is a code owner automatically assigned from Significant-Gravitas/maintainers

@Torantulino Torantulino Awaiting requested review from Torantulino Torantulino is a code owner automatically assigned from Significant-Gravitas/maintainers

@ntindle ntindle Awaiting requested review from ntindle

@Bentlybro Bentlybro Awaiting requested review from Bentlybro

@kcze kcze Awaiting requested review from kcze

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation platform/backend AutoGPT Platform - Back end Review effort [1-5]: 2 size/l
Projects
AutoGPT development kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarushik93 @Swiftyos @majdyz