Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rnd): Fix broken list input pin execution ordering & unlinked dynamic pins on save #8108

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Sep 19, 2024

Background

The input execution on list input pin is currently unordered, and on each save, the link connection is lost.
See [Broken List Input Pin · Issue #8107 · Significant-Gravitas/AutoGPT](#8107).

Changes 🏗️

This PR fixes the provided issue by fixing the input coalescing behaviour on the execution, and avoid removing empty string on hardcoded value, to retain the empty string connection.

Testing 🔍

Note

Only for the new autogpt platform, currently in rnd/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@majdyz majdyz requested review from Bentlybro and kcze September 19, 2024 19:53
@majdyz majdyz requested a review from a team as a code owner September 19, 2024 19:53
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Potential Performance Issue
The new implementation for merging list inputs may lead to unnecessary memory allocation when padding the list with empty strings.

Behavior Change
The changes in removeEmptyStringsAndNulls function for arrays might alter the expected behavior in some cases, as it no longer removes empty strings from arrays.

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/m labels Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 1c6f561
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/66edc416a4da0c0008d84c75

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Sep 20, 2024
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Sep 20, 2024
Copy link
Contributor

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@majdyz majdyz requested a review from ntindle September 20, 2024 17:24
@majdyz majdyz enabled auto-merge (squash) September 20, 2024 23:54
@majdyz majdyz requested a review from kcze September 21, 2024 15:06
@majdyz majdyz merged commit 62a3e1c into master Sep 21, 2024
14 checks passed
@majdyz majdyz deleted the zamilmajdy/open-1850-broken-list-input-pin branch September 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants