Bookstore: initialize project with componentsSet up routers #1
Conversation
SimonGideon
commented
Dec 8, 2022
SimonGideon
commented
- Use React Router.
- Use React components.
There was a problem hiding this comment.
Hi @SimonGideon,
Good job so far 👍🏼
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔️ No linter errors
✔️ Used Gitflow
✔️ Work documented professionally
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/Components/Pages/Cartegory.js
Outdated
| <div> | ||
| <h1>Cartegory</h1> | ||
| </div> |
There was a problem hiding this comment.
- The
Categorycomponent should render a button with the text "check status", kindly implement this so the category page shows a button
| <App /> | ||
| </React.StrictMode> | ||
| <BrowserRouter> | ||
| <App /> |
There was a problem hiding this comment.
- The app doesn't render for some reason, kindly make sure to fix this so your app displays the components in the browser
There was a problem hiding this comment.
🤔 Let me check on my end an correct on the same 👍
SimonGideon
force-pushed
the
set-up-routers
branch
from
6cfa2a4 to
f15c000
Compare
There was a problem hiding this comment.
Hi @SimonGideon, 👋🏻👋🏻
Good job so far! 🔥✨♻💯💯
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Followed Gitflow ✅
- Great working on the functionality 🔥🚀🎉
- Descriptive PR ✅
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| ]; | ||
| return ( | ||
| <ul> | ||
| {books.map((book) => ( | ||
| <li className="Main-content" key={book.id}> | ||
| <Book title={book.title} author={book.author} /> | ||
| <button type="button">Remove</button> | ||
| </li> | ||
| ))} | ||
| </ul> |
There was a problem hiding this comment.
- I think there is still a problem while rendering the page as the previous code reviewer requested so kindly make sure to solve the problem, now it shows me this error here 👍 and I can't see any Booklist or form to add a new book ✨
