Move requestWindowFeature before onCreate #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notandyvee
changed the title
danilo04
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Hi @notandyvee, I tested your change on the simplenote PR and everything is working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When updating kotlin on simple note, it crashed due to the
requestWindowFeaturebeing called afteronCreate. I don't fully understand the issue. But a quick google search pointed out that it should be called beforeonCreate.Test
You can load the PR linked to see how it works. Before the app loading crashed immediately. No immediate crash means it's fixed.