Skip to content

Commit

Permalink
fix(deps): fix fastify working versions
Browse files Browse the repository at this point in the history
  • Loading branch information
Alexander Kureniov committed Feb 24, 2020
1 parent fac383e commit fbfccc1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = fp(
return openapi(fastify, opts);
},
{
fastify: '<2.12.0',
fastify: '>=2.0.0 <2.12.0 || >=2.12.1 <3.0.0',
name: 'fastify-oas',
},
);

8 comments on commit fbfccc1

@adrai
Copy link
Contributor

@adrai adrai commented on fbfccc1 Apr 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SkeLLLa any info if it will work for new fastify v3?

@SkeLLLa
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should, but we'll need some testing. So we just need some tests.

@adrai
Copy link
Contributor

@adrai adrai commented on fbfccc1 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the new schema ref stuff will not work: https://github.com/fastify/fastify/blob/master/docs/Migration-Guide-V3.md#changed-schema-substitution-2023

@SkeLLLa
Copy link
Owner

@SkeLLLa SkeLLLa commented on fbfccc1 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe/ But actually $ref support were added some time before to fastify-oas, so there's a change that it will work.
I'm planning to create new branch for 3.x stuff testing. If you want to experiment as well - PRs always appreciated.

@adrai
Copy link
Contributor

@adrai adrai commented on fbfccc1 May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have done a first quick test: #30

@MichielDeMey
Copy link

@MichielDeMey MichielDeMey commented on fbfccc1 May 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can go ahead and create the 3.x branch and change the fastify version requirement to include v3?

My API schemas currently don't use the $ref but this module throws an error about the required fastify version even though it works on v3 (without $ref usage).

That way we can simply add "fastify-oas": "SkeLLLa/fastify-oas#3.x" to our package.json in the meanwhile.

@SkeLLLa
Copy link
Owner

@SkeLLLa SkeLLLa commented on fbfccc1 May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichielDeMey give me couple of hours and I create branches and publish @next tag to npm.

@SkeLLLa
Copy link
Owner

@SkeLLLa SkeLLLa commented on fbfccc1 May 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichielDeMey
https://github.com/SkeLLLa/fastify-oas/tree/next
https://www.npmjs.com/package/fastify-oas/v/3.0.0-rc.0

Please sign in to comment.