Skip to content

Commit

Permalink
fix: corrected generation of metadata attribute name from container i…
Browse files Browse the repository at this point in the history
…mage sha and servicename
  • Loading branch information
tmeckel committed Aug 25, 2024
1 parent 44d6825 commit efd40eb
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
4 changes: 3 additions & 1 deletion stack/cloud_run_offset_tile.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@
container_concurrency=1,
),
metadata=dict(
name=service_name + "-" + cloud_run_images.cloud_run_offset_tile_sha,
name=cloud_run_images.cloud_run_offset_tile_sha.apply(
lambda sha: f"{service_name}-{sha}"
),
annotations={
"autoscaling.knative.dev/maxScale": "2000",
},
Expand Down
4 changes: 3 additions & 1 deletion stack/cloud_run_orchestrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@
container_concurrency=1,
),
metadata=dict(
name=service_name + "-" + cloud_run_images.cloud_run_orchestrator_sha,
name=cloud_run_images.cloud_run_orchestrator_sha.apply(
lambda sha: f"{service_name}-{sha}"
),
annotations={
"run.googleapis.com/cloudsql-instances": instance.connection_name,
"autoscaling.knative.dev/maxScale": "45",
Expand Down
4 changes: 3 additions & 1 deletion stack/cloud_run_tipg.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@
timeout_seconds=420,
),
metadata=dict(
name=service_name + "-" + cloud_run_images.cloud_run_tipg_sha,
name=cloud_run_images.cloud_run_tipg_sha.apply(
lambda sha: f"{service_name}-{sha}"
),
annotations={
"run.googleapis.com/cloudsql-instances": instance.connection_name,
},
Expand Down

0 comments on commit efd40eb

Please sign in to comment.