Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✦ Speed Status Bar #855

Closed
IllagerCaptain opened this issue Jul 20, 2024 · 7 comments · Fixed by #945
Closed

✦ Speed Status Bar #855

IllagerCaptain opened this issue Jul 20, 2024 · 7 comments · Fixed by #945
Labels
new feature This issue or PR is a new feature

Comments

@IllagerCaptain
Copy link
Contributor

Describe the new feature.

Similar to I think it was SkyBlock add-ons, a speed status bar on the hud would be cool. It'd probably be hidden by default and have to be dragged into place in the config screen.

Regarding calculating speed, I believe the best approach would be calculating the attribute $generic.movement\_speed × 1000$.

Images

No response

@IllagerCaptain IllagerCaptain added the new feature This issue or PR is a new feature label Jul 20, 2024
@AzureAaron
Copy link
Collaborator

I think it would probably be better as a just some text you can freely move around since I don't know if speed is fit for a bar.

@lunaynx
Copy link
Contributor

lunaynx commented Jul 20, 2024

Regarding calculating speed, I believe the best approach would be calculating the attribute generic.movement_speed×1000.

Yeah, that should be the best for the majority of cases, as it will show the effective movement speed and doesn't require the stat to be enabled in the tab list widget.

There are a few cases where you can have a speed cap above 500 but your effective speed is still capped to 500% (is this still a thing on newer Minecraft versions?), which may matter for things like the Warden Helmet, but those are niche cases and the players can probably just check their stats menu or tab list instead.

I'd also note that the Rift is a special case where potion effects such as Speed affect your effective movement speed but not generic.movement_speed, but it's probably not a big deal either.

@MisterCheezeCake
Copy link

The way I calculate it over in SBT is player.getMovementSpeed() * 1000 (and dividing that by 1.3 if sprinting), in my tests, that always seems to give the accurate Skyblock Speed Stat.

@BigloBot
Copy link
Contributor

BigloBot commented Jul 20, 2024

I think it would probably be better as a just some text you can freely move around since I don't know if speed is fit for a bar.

tbf the way the status bars work, it's a far better fit than the armour one.

Speed has a cap, as well as current speed

Amour just x Defence out of ????

@Emirlol
Copy link
Collaborator

Emirlol commented Jul 20, 2024

What if we just had the option to toggle bars around the text to make them more compact if the user desires so? Nvm I thought this was about the colored rectangle and the title of gui widgets

@viciscat
Copy link
Collaborator

I think it would probably be better as a just some text you can freely move around since I don't know if speed is fit for a bar.

tbf the way the status bars work, it's a far better fit than the armour one.

Speed has a cap, as well as current speed

Amour just x Defence out of ????

the bar represents the percentage of damage you are protected from iirc

@IllagerCaptain
Copy link
Contributor Author

I'd also note that the Rift is a special case where potion effects such as Speed affect your effective movement speed but not generic.movement_speed, but it's probably not a big deal either.

Aren't bars disabled in the rift?

@AzureAaron AzureAaron linked a pull request Aug 22, 2024 that will close this issue
kevinthegreat1 added a commit that referenced this issue Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants