-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Speed Status Bar #855 #945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well and the code looks pretty good so uh good job 👍
Did not test the max speed exceptions tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great; just one thing.
src/main/java/de/hysky/skyblocker/config/configs/UIAndVisualsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/fancybars/FancyStatusBars.java
Outdated
Show resolved
Hide resolved
…onfig.java Co-authored-by: Kevin <[email protected]>
…usBars.java Co-authored-by: Kevin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at that but I don't think that it's any bigger of an issue than it was before this change. I could change the default positioning of it, but at that point why not change the defaults of all of them? |
Yeah. I'm just leaving that here in case someone wants to modify the defaults for all the bars. We can merge this pr already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the defaults a bit.
Thanks for contributing! |
In order to solve the issue #855, I implemented a speed status bar in the way that was discussed in that issue (r.e. speed calculations), and added it to all the same places as the existing health, mana, defence, and experience bars. I created a texture for it.
I have tested the bar and most of the exceptions to the 400 speed cap in game. I have not tested the racing helmet nor the black cat pet as I don't have the money for that, but since they work in the same way as the other exceptions I see no reason why they shouldn't work.
I tested: