Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Networth Calculator + Fix EMI Log Spam #1001

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Update Networth Calculator + Fix EMI Log Spam #1001

merged 1 commit into from
Sep 20, 2024

Conversation

AzureAaron
Copy link
Collaborator

  • Update Networth calculator to fix bugs, crashes, and optimize performance slightly for some calculations
  • Fix EMI Log Spam
    • We created illegal profile components with names longer than 16 characters which causes exceptions to be thrown when the items are attempted to be serialized by EMI (and maybe other mods and whatnot)

@AzureAaron AzureAaron added bug Something isn't working compatibility Adds compatibility for a new Minecraft version or a compatibility issue with other mods crash This is a crash small change Small changes that are easier to review labels Sep 17, 2024
@AzureAaron AzureAaron added this to the 1.23.0 milestone Sep 17, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Sep 17, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Sep 17, 2024
@AzureAaron AzureAaron merged commit 70f6532 into SkyblockerMod:master Sep 20, 2024
1 check passed
@AzureAaron AzureAaron deleted the networth-update branch September 20, 2024 03:16
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working compatibility Adds compatibility for a new Minecraft version or a compatibility issue with other mods crash This is a crash small change Small changes that are easier to review
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AzureAaron @kevinthegreat1 @LifeIsAParadox