Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mob glow refactor #1101

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Mob glow refactor #1101

merged 3 commits into from
Dec 24, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

Update at most once per tick instead of three times per frame.

Note: this doesn't delay things. The glow is still calculated on render, just cached.

Screenshot 2024-12-23 at 17 50 07

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Dec 24, 2024
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Dec 24, 2024
@kevinthegreat1 kevinthegreat1 merged commit 2335b31 into SkyblockerMod:master Dec 24, 2024
1 check passed
@kevinthegreat1 kevinthegreat1 deleted the mob-glow-refactor branch December 24, 2024 21:07
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinthegreat1 @AzureAaron @LifeIsAParadox