Profiled data api #1102
Merged
Profiled data api #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LifeIsAParadox
added
reviews needed
|
It's usable as is, so I'll mark this as ready. |
AzureAaron
requested changes
Jan 4, 2025
src/main/java/de/hysky/skyblocker/utils/profile/ProfiledData.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public CompletableFuture<Void> init() { | ||
| ClientLifecycleEvents.CLIENT_STOPPING.register(client -> save()); |
There was a problem hiding this comment.
You could stuff this at the end of the constructor and delete the method.
There was a problem hiding this comment.
I need to return a completable future.
src/main/java/de/hysky/skyblocker/utils/profile/ProfiledData.java
Outdated
Show resolved
Hide resolved
| return containsKey(Utils.getUuid(), Utils.getProfileId()); | ||
| } | ||
|
|
||
| public boolean containsKey(UUID uuid, String profileId) { |
There was a problem hiding this comment.
I'm not sure the containsKey (mainly the key) terminology is very clear or helpful here. It would be better off as containsSave (not great) or smth similar but you get the idea.
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces pet cache, end stats, museum, accessory helper, slayer timer, and powder mining tracker.